Skip to content

Commit

Permalink
chore: make helperText Field property optional (#218)
Browse files Browse the repository at this point in the history
This is a partial revert of 4ce47f0.
Fields' `helperText` property doesn't need to be required.

This is *arguably* a breaking change, but because it's making a required
field optional, I don't think it is.
  • Loading branch information
EvanHahn committed Aug 25, 2024
1 parent 4e9b724 commit a220065
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 10 deletions.
2 changes: 1 addition & 1 deletion proto/field/v1.proto
Original file line number Diff line number Diff line change
Expand Up @@ -38,5 +38,5 @@ message Field_1 {
repeated Option options = 10;
bool universal = 11;
optional string placeholder = 12;
string helperText = 13;
optional string helperText = 13;
}
9 changes: 1 addition & 8 deletions schema/field/v1.json
Original file line number Diff line number Diff line change
Expand Up @@ -102,13 +102,6 @@
"type": "string"
}
},
"required": [
"tagKey",
"type",
"label",
"schemaName",
"universal",
"helperText"
],
"required": ["tagKey", "type", "label", "schemaName", "universal"],
"additionalProperties": false
}
1 change: 0 additions & 1 deletion test/fixtures/good-docs-minimal.js
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@ export const goodDocsMinimal = [
type: 'text',
deleted: false,
universal: false,
helperText: '',
},
expected: {},
},
Expand Down

0 comments on commit a220065

Please sign in to comment.