-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
install buf via npm #110
install buf via npm #110
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to remove this https://github.com/digidem/mapeo-schema/blob/master/scripts/generate.js#L24
Otherwise looks good.
@gmaclennan don't we need to keep that but update it to either update it or extract that command to the |
oops yeah I had assumed the |
Thanks! Updated to fix the things mentioned. |
@sethvincent now that you updated the npm script I think you can remove the line in the Other than that, lgtm! |
closes #105
closes #33
This installs buf from npm and moves the buf command usage out of ci jobs and into a package.json script that's included in
build:all
.