Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add optional deviceType to deviceInfo #164

Merged
merged 1 commit into from
Feb 8, 2024
Merged

Conversation

gmaclennan
Copy link
Member

@gmaclennan gmaclennan self-assigned this Jan 31, 2024
Copy link
Contributor

@EvanHahn EvanHahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming my enum question isn't a problem.

test/fixtures/good-docs-completed.js Show resolved Hide resolved
proto/deviceInfo/v1.proto Show resolved Hide resolved
@gmaclennan gmaclennan merged commit dccea71 into main Feb 8, 2024
6 checks passed
@gmaclennan gmaclennan deleted the feat/add-device-type branch February 8, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants