chore!: remove refs property from schemas
#196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This isn't necessary for now, so we can remove it. `refs` is still present for `Track`s. Tested this with automated tests and by integrating it into `@mapeo/core` with a temporary build of this module.
|
Aproved, but wondering, why are we keeping refs on tracks? |
tomasciccola
approved these changes
Jul 22, 2024
|
I don't know much about tracks so I don't know if they're needed. I'll ask. |
This was referenced Aug 1, 2024
This was referenced Aug 24, 2024
This was referenced Sep 2, 2024
This was referenced Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't necessary for now, so we can remove it.
refsis still present forTracks.Tested this with automated tests and by integrating it into
@mapeo/corewith a temporary build of this module.Closes #193.