Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove anys from decode helper function #247

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

EvanHahn
Copy link
Contributor

@EvanHahn EvanHahn commented Sep 3, 2024

This change should have no user impact.

It's generally good to avoid anys, as they worsen type safety. This removes 3 of them in a decode helper function.

This change should have no user impact.

It's generally good to avoid `any`s, as they worsen type safety. This
removes 3 of them in a `decode` helper function.
Copy link
Member

@gmaclennan gmaclennan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine... but this doesn't change type safety, it's just a syntax change.

@EvanHahn EvanHahn merged commit 0691e74 into main Sep 4, 2024
6 checks passed
@EvanHahn EvanHahn deleted the remove-an-any-when-decoding branch September 4, 2024 13:14
gmaclennan added a commit that referenced this pull request Sep 9, 2024
* main:
  test: test validating a schema name that could "trick" JavaScript (#250)
  test: properly test more `validate` errors (#249)
  fix: observation metadata types (#248)
  chore: remove `any`s from decode helper function (#247)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants