Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Change prop names and type names [5/6] #77

Merged
merged 8 commits into from
Aug 1, 2023
Merged

fix: Change prop names and type names [5/6] #77

merged 8 commits into from
Aug 1, 2023

Conversation

gmaclennan
Copy link
Member

Following discussion with @achou11:

  • Rename id -> docId
  • Rename version -> versionId
  • Export types for "values", e.g. without common props. These are the types for update/create actions.
  • Name "value" types as ${schemaName}Value
  • Rename union of all Mapeo types as MapeoDoc

@gmaclennan gmaclennan linked an issue Jul 27, 2023 that may be closed by this pull request
Finalize schema definitions for data & config core records #70
Closed
@gmaclennan gmaclennan changed the title fix: Change prop names and type names fix: Change prop names and type names [5/6] Jul 28, 2023
@gmaclennan gmaclennan mentioned this pull request Jul 28, 2023
Closed
gmaclennan and others added 2 commits July 28, 2023 17:54
@gmaclennan
fix: fix type error
d29dfd7
@optic-release-automation
Release v3.0.0-next.4 (#86)
e242c10 
Co-authored-by: gmaclennan <actions@users.noreply.github.com>
@tomasciccola tomasciccola merged commit e8220f7 into chore/build-cleanup Aug 1, 2023
gmaclennan added a commit that referenced this pull request Aug 1, 2023
@gmaclennan @optic-release-automation
fix: Change prop names and type names [5/6] (#77)
73bda10 
* fix!: id -> docId version -> versionId

* chore!: rename type exports

* Add schemaName to MapeoCommon

* fix: Simplify exported types

This improves type hints in editors

* Avoid double Position export for observation.ts

This was caused by (probably a bug in json-schema-ts) that
caused the referenced definition to be duplicated.

* fix: Strict types for validate function

* fix: fix type error

* Release v3.0.0-next.4 (#86)

Co-authored-by: gmaclennan <actions@users.noreply.github.com>

---------

Co-authored-by: optic-release-automation[bot] <94357573+optic-release-automation[bot]@users.noreply.github.com>
Co-authored-by: gmaclennan <actions@users.noreply.github.com>
@gmaclennan
Copy link
Member Author

Actual squash-merge commit 73bda10

@gmaclennan gmaclennan self-assigned this Aug 7, 2023
@gmaclennan gmaclennan deleted the fix/schema-updates branch September 4, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gmaclennan gmaclennan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Finalize schema definitions for data & config core records
2 participants
@gmaclennan @tomasciccola