Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add missing fields to authStore schemas/protos #93

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

tomasciccola
Copy link
Contributor

This PR adds missing fields to authStore Schemas and protobufs.
Things that can be revised:

  • some fields name *Id that are typed as string on the protobuf could be of type bytes.
  • capabilityType is a string but can be an enum. Looking at this code I don't know this should be the name of the role (projectCreator | coordinator | member | non-member) or the capabilities (read | write | manage:devices).

This should close PR #44

@tomasciccola tomasciccola self-assigned this Aug 2, 2023
Copy link
Member

@gmaclennan gmaclennan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Ok to leave possible enums as strings for now, and we can review later.

@gmaclennan gmaclennan merged commit 7dc04fb into master Aug 3, 2023
0 of 6 checks passed
@gmaclennan gmaclennan deleted the feat/add-configstore-fields branch August 3, 2023 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants