Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update deps #6

Merged
merged 5 commits into from
Jul 6, 2023
Merged

update deps #6

merged 5 commits into from
Jul 6, 2023

Conversation

sethvincent
Copy link
Contributor

The primary change that was needed after updating deps was updating all the random access storage module usage to be classes rather than functions.

gmaclennan
gmaclennan approved these changes Dec 15, 2022
View reviewed changes
Copy link
Member

@gmaclennan gmaclennan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. I don't really like the class constructors all in lower-case, but I guess there is not harm in it! Fine to merge as-is, or do a search-replace /new ram()/new Ram()/ before merging :)

@gmaclennan
Merge branch 'main' into update-deps
04c6fd7 
* main:
  chore(release): 1.0.0-alpha.1
  fix: stricter types and publish typescript declarations (#7)
  feat: state getter (#5)
@gmaclennan
chore: update deps not in merge commit
e980392
@gmaclennan
fix: Ignore missing coverage for backpressure
62f3a35 
We don't yet properly test for back pressure. This was only covered
before because a slow state machine in streamx was resulting in
backpressure here, but the fixes in
mafintosh/streamx#77
resulted in no backpressure, so this line became uncovered by tests
@gmaclennan
fix: fix for random-access-memory@6
5080daa
@gmaclennan gmaclennan merged commit 84a39f7 into main Jul 6, 2023
2 checks passed
@gmaclennan gmaclennan deleted the update-deps branch July 6, 2023 14:39
@gmaclennan gmaclennan mentioned this pull request Jul 6, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmaclennan gmaclennan gmaclennan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sethvincent @gmaclennan