Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix public upload #359

Merged
merged 1 commit into from
Jun 27, 2022
Merged

Fix public upload #359

merged 1 commit into from
Jun 27, 2022

Conversation

timobrembeck
Copy link
Member

Short description

Fix public upload

Proposed changes

  • Remove outdated name field from image creation

Resolved issues

Fixes: #358

@timobrembeck timobrembeck requested a review from a team as a code owner June 27, 2022 09:29
@JoeyStk
Copy link
Contributor

JoeyStk commented Jun 27, 2022

Thank you a lot!
Extra thanks for the quick response. Is there a way to test this? I wasn't able to reproduce the error on my local machine

@timobrembeck
Copy link
Member Author

timobrembeck commented Jun 27, 2022 •
edited
Loading

Is there a way to test this? I wasn't able to reproduce the error on my local machine

Yes, when you run the system on the develop branch and navigate to http://localhost:8080/public_upload you should be able to reproduce the error (and then you can switch to my branch and check whether the error is now fixed).

JoeyStk
JoeyStk approved these changes Jun 27, 2022
View reviewed changes
Copy link
Contributor

@JoeyStk JoeyStk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
This is working as expected! :)

@timobrembeck timobrembeck merged commit 91ab812 into develop Jun 27, 2022
@timobrembeck timobrembeck deleted the bugfix/image-upload branch June 27, 2022 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoeyStk JoeyStk JoeyStk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Uploading images not working
2 participants
@timobrembeck @JoeyStk