Make sure webpack exits with non-zero status when there are errors. F…

…ixes #115.
dillonkearns · Jun 16, 2020 · 36a93d6 · 36a93d6
1 parent 53d6c99
commit 36a93d6
Showing 1 changed file with 26 additions and 26 deletions.
diff --git a/generator/src/develop.js b/generator/src/develop.js
@@ -98,35 +98,35 @@ function run({ routes, manifestConfig }) {
     })
   ).run((err, stats) => {
     if (err) {
-      console.error(err);
+      process.exit(1);
+    } else if (stats.compilation.errors && stats.compilation.errors.length > 0) {
+      console.error(stats.compilation.errors);
       process.exit(1);
     } else {
-      // done
-    }
+      console.log(
+        stats.toString({
+          chunks: false, // Makes the build much quieter
+          colors: true, // Shows colors in the console
+          // copied from `'minimal'`
+          all: false,
+          modules: false,
+          performance: true,
+          timings: false,
+          outputPath: true,
+          maxModules: 0,
+          errors: true,
+          warnings: true,
+          // our additional options
+          moduleTrace: false,
+          errorDetails: false
+        })
+      );
 
-    console.log(
-      stats.toString({
-        chunks: false, // Makes the build much quieter
-        colors: true, // Shows colors in the console
-        // copied from `'minimal'`
-        all: false,
-        modules: false,
-        performance: true,
-        timings: false,
-        outputPath: true,
-        maxModules: 0,
-        errors: true,
-        warnings: true,
-        // our additional options
-        moduleTrace: false,
-        errorDetails: false
-      })
-    );
-
-    const duration = roundToOneDecimal(
-      (stats.endTime - stats.startTime) / 1000
-    );
-    console.log(`Duration: ${duration}s`);
+      const duration = roundToOneDecimal(
+        (stats.endTime - stats.startTime) / 1000
+      );
+      console.log(`Duration: ${duration}s`);
+    }
   });
 }