Makes BackendTask.combine stack safe #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for elm-pages-todos pending review.Visit the deploys page to approve it
|
andrewMacmurray
changed the title
andrewMacmurray
changed the title
|
Thanks so much for the PR Andrew! 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi 👋 I thought I'd suggest adding these from my explorations in making stack safe tasks!
Currently if you run
BackendTask.combinewith lots of tasks (> 10K on my machine) it blows up, but weirdly if you sub-batch smaller lists of tasks and re-concat them at the end it works with ~1M tasks. It's a bit of a weird trick and there's probably a way of doing it without the Lists but that's the best I've found so far (I have tried many, many things! 😂 ).