Fix FilesAndFolders in Glob

[miniBill]

No description provided.

[netlify]

👷 Deploy request for elm-pages-todos pending review.

Visit the deploys page to approve it

Name	Link
🔨 Latest commit	b0c54cf

[dillonkearns]

I just caught this as well! I think I beat you to the fix on master:

elm-pages/src/BackendTask/Glob.elm

Lines 1046 to 1065 in e0c363a

	, ( "onlyFiles"
	, (if options.include == FilesAndFolders then
	False
	else
	options.include == OnlyFiles
	)
	|> Encode.bool
	)
	|> Just
	, ( "onlyDirectories"
	, (if options.include == FilesAndFolders then
	False
	else
	options.include == OnlyFolders
	)
	|> Encode.bool
	)
	|> Just

So I think we can close this one. Thanks for the PR!

[miniBill]

With some more testing I actually think neither my version nor yours are correct? If I try to run it and target a socket file it just... hangs
Nevermind, I had updated the Elm side but not the JS side

[miniBill]

[This, by the way, is a failure mode I've observed in the past: if something happens such that Elm doesn't get an answer it expects the whole script just... hangs in there]

[dillonkearns]

Yeah, the DX for working on the internal implementations for BackendTask runners is not so great, I am annoyed by it regularly as well. Would be nice to improve the error handling for faster iteration in development on those implementations.

[miniBill]

My DX is yarn add -D ../elm-pages; yarn elm-pages run script/path.
It's pretty decent

[dillonkearns]

Oh yeah, I just work on example scripts in examples/end-to-end/script/src/ and run npx elm-pages run script/src/MyExample.elm. That part works great.

I meant the DX of things hanging instead of just having a clear error message and exiting when something goes wrong in the implementations in render.js. That would be nice to improve for iteration in dev.