Keep dev server running for non-fatal errors. #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dillonkearns
force-pushed
the
keep-running-on-non-fatal-errors
branch
from
5e43bcb
to
d22521a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #56.
Current state
The dev server will continue to run with these non-fatal errors:
It will terminate the dev server loop with these fatal errors:
StaticHttprequest failedStaticHttprequest failedSecret(i.e. environment variable that aStaticHttprequest depends on)If StaticHttp requests could be retried infinite times with no penalty, it would simplify things because we could just greedily try running them again whenever the code changed and keep the dev server running. But Because we have to consider rate limiting and other potential issues with repeatedly hitting an API, for now the strategy is to just let the user re-run the CLI. This is probably good enough, but it might be worth revisiting this at some point to find a more sophisticated approach.
It's also worth noting that
StaticHttprequests are not performed again when they change while the dev server is running, so you currently have to re-run it. This may be worth revisiting at some point, too, but the same tradeoffs apply regarding rate limiting.