Fix delta_time being 0 resulting in incorrect simulation #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vrixyz
commented
Jun 21, 2024
Vrixyz
commented
Jun 21, 2024
| @@ -221,7 +221,11 @@ impl IntegrationParameters { | |||
| pub fn joint_cfm_coeff(&self) -> Real { | |||
| // Compute CFM assuming a critically damped spring multiplied by the damping ratio. | |||
| // The logic is similar to `Self::cfm_factor`. | |||
There was a problem hiding this comment.
should a similar correction be applied to cfm_factor ?
There was a problem hiding this comment.
also, the correct function referred to is probably contact_cfm_factor ?
This was referenced Jun 21, 2024
Vrixyz
commented
Jun 21, 2024
Vrixyz
commented
Jun 21, 2024
sebcrozet
reviewed
Jun 21, 2024
Vrixyz
force-pushed
the
659-fix_delta_time_0_NaN
branch
from
d613e64
to
e4e3135
Compare
Vrixyz
commented
Jun 21, 2024
sebcrozet
reviewed
Jun 21, 2024
Vrixyz
force-pushed
the
659-fix_delta_time_0_NaN
branch
from
90736e3
to
4dcd38e
Compare
|
Thanks! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #659.
Bug introduced by #635.
Disclaimer: I am NOT confident about the correction, but I'm confident it's the correct place to fix :).