Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gateway v3 #236

Merged
merged 11 commits into from
Sep 27, 2023
Merged

Gateway v3 #236

merged 11 commits into from
Sep 27, 2023

Conversation

seailz
Copy link
Member

@seailz seailz commented Sep 25, 2023

PR Details

  • I have checked the PRs for upcoming features/bug fixes.

What you've changed

  • Developer-facing library
  • Internal Code
  • Documentation

Closes #0

Description

Version 3 implementation of the Gateway, designed to be much more stable, reliable, and well implemented.

Currently implemented the base of it and it needs proper implementation with the rest of the codebase.

@seailz seailz added status: in progress PR or issue is currently in progress type: feature Issue or PR is a feature that should be implemented priority: high High priority LARGE PR or issue with a large amount of additions IMPORTANT Important PR or issue that is important to be added/implemented soon. type: enhancement status: awaiting testing labels Sep 25, 2023
@seailz seailz added this to the discord.jar 1.0 milestone Sep 25, 2023
@seailz seailz self-assigned this Sep 25, 2023
@seailz seailz added status: completed and removed status: in progress PR or issue is currently in progress labels Sep 25, 2023
@seailz
Copy link
Member Author

seailz commented Sep 25, 2023

awaiting long-term testing

@seailz seailz marked this pull request as draft September 25, 2023 20:43
@seailz
fix(heart): fixed an issue with HeartLogic.java where it would attemp…
a4add7a 
…t to send heartbeats to closed connections due to the logic of the Gateway.java class

Gateway.java creates a new WebSocket instance for each connection, but HeartLogic.java wasn't being told to stop sending heartbeats after a connection had closed, causing a broken pipe SocketException. This has been fixed by stopping the heartbeat manager on a disconnect.
@seailz
feat(gateway): added some extra getters to Gateway.java
329f54d
@seailz
refactor(gateway): reorganized some elements
6e919fa
@seailz
javadocs(gateway): added proper javadocs for the gateway class & methods
0f75f39
@seailz
fix(heartbeat): fixed heartbeat cycling
bcf6bb6
@seailz
fix(heartbeat): fixed heartbeat cycling
f217d41
@seailz
fix(gateway / status rotor): fixed issues with the new gateway implem…
1ac4c53 
…entation where having an active status rotor would cause the gateway to crash after a disconnect and attempted reconnect

This was due to the status rotor attempting to send a message when it wasn't authorized to do so, since the ready event hadn't yet been received.
@seailz
fix(statuses): more fixes with statuses
8c93196
@seailz
fix(statuses): more fixes with statuses
7568477
@seailz seailz marked this pull request as ready for review September 27, 2023 08:02
@seailz seailz merged commit a877d2e into main Sep 27, 2023
3 checks passed
@seailz seailz deleted the feature/gatewayv3 branch September 27, 2023 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@seailz seailz

Labels
IMPORTANT Important PR or issue that is important to be added/implemented soon. LARGE PR or issue with a large amount of additions priority: high High priority status: completed type: enhancement type: feature Issue or PR is a feature that should be implemented
Projects
None yet
Milestone
discord.jar 1.0
Development

Successfully merging this pull request may close these issues.
1 participant
@seailz