-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] - Implement GRPC executor #1049
Conversation
1b759be
to
49a0f0b
Compare
49a0f0b
to
043c59e
Compare
@vcastellm can you take a look? |
043c59e
to
d12c448
Compare
@vcastellm did you have the opportunity to take a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall but I'm missing documentation and some example use cases for this.
I added usage documentation. Can you point me in the direction that you pretend? |
@vcastellm I would love to merge this. Also is it possible to release after merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM aside from the typo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you rebase with master?
Signed-off-by: Paulo Moura <itsme@paulomoura.com.pt>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Espina2
@vcastellm any way that we can make a release of this? |
@Espina2 It will be included in the next release |
When will that happen? |
@Espina2 I want to release |
Implement GRPC executor relaying in GRPC server reflection to get proto descriptors and serialize protobufs from JSON.
Out of scope:
Signed-off-by: Paulo Moura itsme@paulomoura.com.pt