Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add TLS options for kafka executor plugin #1384

Merged

Conversation

hosseinsadeghi-cpi
Copy link
Contributor

This PR adds TLS configurations for Kafka executor to enable users to communicate with Kafka clusters protected with encryption.

builtin/bins/dkron-executor-kafka/kafka.go Dismissed Show dismissed Hide dismissed
Copy link
Collaborator

@yvanoers yvanoers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for the contrib!

@vcastellm vcastellm merged commit b71134b into distribworks:master Sep 15, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants