-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle ip changes #1446
Handle ip changes #1446
Conversation
Thanks your this contribution, really appreciated, can you add a simple test file to cover Also, can you switch base branch to https://github.com/distribworks/dkron/tree/4.x branch instead? we'll focus on that at this point. |
…ent from server node IP on raft layer
991574f
to
986ef63
Compare
yes, sure |
f9c445b
to
98be95b
Compare
…in server_lookup.go)
98be95b
to
2d3e3d9
Compare
@vcastellm how is this PR looking? I'm trying to get a sense of when this might get merged and also a rough idea of when 4.x is coming. |
First v4 beta in the following hours |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM great job!
Pull request is associated with issue #1442
I made several things here:
Query each of the servers and make sure they report no Raft peers.
(I'm not sure if it is correct approach)I built image and tested it in k8s using this helm - distribworks/dkron-helm#7
Seems like everything works fine now