Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github Action for release (binary and docker) #770

Merged
merged 1 commit into from
Sep 4, 2020

Conversation

fopina
Copy link
Contributor

@fopina fopina commented May 22, 2020

  • Added release.yml workflow to run goreleaser and docker build/push only for tags
  • Excluded tags from main.yml workflow (as tags should have been tested when pushed to the branch and avoids re-running workflows on the same commits)
  • Removed docker build from goreleaser to separate step using buildkit -> allows for multi-arch builds -> GoReleaser has had this open 2 years Support multi-platform docker images goreleaser/goreleaser#530 and it's still about the previous way (building each image and bundling the docker manifest), buildkit does it all in one go
  • scripts/release no longer required, but left in case you want to do some manual release
  • added arm/v7 build (for raspberry pi)
➜  dkron git:(fopina-patch-ga) docker run --rm dkron/dkron version
Name: Dkron
Version: 3.0.2
Codename: merichuas
Agent Protocol: 5 (Understands back to: 2)
➜  dkron git:(fopina-patch-ga) ssh sfpi docker run --rm dkron/dkron version
standard_init_linux.go:211: exec user process caused "exec format error"
➜  dkron git:(fopina-patch-ga) docker run --rm fopina/dkron:v3.0.2-12 version
Name: Dkron
Version: 3.0.2-12
Codename: merichuas
Agent Protocol: 5 (Understands back to: 2)
➜  dkron git:(fopina-patch-ga) ssh sfpi docker run --rm fopina/dkron:v3.0.2-12 version
Name: Dkron
Version: 3.0.2-12
Codename: merichuas
Agent Protocol: 5 (Understands back to: 2)

Left a few "fork friendly" items in workflow that won't affect dkron/dkron and make it easy to release patched versions from forks :D but we remove of course, if you prefer.

@fopina
Copy link
Contributor Author

fopina commented May 29, 2020

@Victorcoder and no <3 for this one too ^^ ?
Took quite a few builds to get it right 🔨

@fopinappb
Copy link

out of curiosity @Victorcoder , what leaves you uneasy on this PR? it's the simple change to GA that we discussed in gitter :)

@vcastellm
Copy link
Member

Sorry for the delay @fopina didn't have time to look into it until now

@meshchaninov
Copy link

This works fine in rusberry pi 4 (ubuntu)

Copy link
Member

@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the comment it LGTM, thanks!

--platform linux/amd64,linux/arm64,linux/arm/v7 \
--build-arg VERSION=${{ steps.prepare.outputs.tag_name }} \
--push \
-t ${DOCKER_REPO:-dkron/dkron}:${{ steps.prepare.outputs.tag_name }} \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is missing the Major version tag

Copy link
Member

@vcastellm vcastellm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm merging this, I will add the tag

@vcastellm vcastellm merged commit 2b92ec6 into distribworks:master Sep 4, 2020
@fopina
Copy link
Contributor Author

fopina commented Sep 4, 2020

Sorry, away from computer these days. Cool!

@fopina fopina deleted the fopina-patch-ga branch January 22, 2023 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants