Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ADP spares #89

Merged
merged 2 commits into from
Sep 24, 2020
Merged

Support ADP spares #89

merged 2 commits into from
Sep 24, 2020

Conversation

ngarratt
Copy link
Contributor

CDOT with Advanced Drive Partitioning (typical in AFF configurations) doesn't report spares in a separate spares container. They can only be accessed at the Aggregate level (aggr-spare-get-iter).

Also fixing a compatibility issue with older perl.

@willemdh
Copy link
Collaborator

@ngarratt Please resolve conflicts and I'll try your pr

@ngarratt
Copy link
Contributor Author

ngarratt commented Sep 24, 2020

FTR, these are our results with the patch (ADP is expected to have only a single shared spare)

ADP:
<cluster>_01: 1 spare disks (0 not zeroed) and 0 unassigned, <cluster>_02: 1 spare disks (0 not zeroed) and 0 unassigned

Hybrid pool:
<cluster>-01: 3 spare disks (0 not zeroed) and 0 unassigned, <cluster>-02: 3 spare disks (0 not zeroed) and 0 unassigned

@willemdh willemdh merged commit 421e7e9 into district09:master Sep 24, 2020
@willemdh
Copy link
Collaborator

Looking good @ngarratt
If you let me know your full name, I can add you to the contributors.
Tx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants