Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use overlay for devshell #367

Merged
merged 2 commits into from
Jan 8, 2024
Merged

Use overlay for devshell #367

merged 2 commits into from
Jan 8, 2024

Conversation

whs-dot-hk
Copy link
Contributor

Greetings @blaggacao

Context

Two days ago, a PR was merged on devshell side removing legacyPackages
https://github.com/numtide/devshell/pull/289/files#diff-206b9ce276ab5971a2489d75eb1b12999d4bf3843b7988cbe8d687cfde61dea0L13
lead to the follow error

error: attribute 'legacyPackages' missing

       at /nix/store/w36lpbbhyghaqdbzcnda35y27knsiblk-incl/lib/dev/mkShell.nix:58:5:

           57|   in
           58|     devshell.legacyPackages.mkShell {
             |     ^
           59|       imports = [configuration nixagoModule];

Solution

Today, pkgs overlays still support by devshell, so we can switch to use it to fix this issue

@blaggacao blaggacao merged commit 5ce7c94 into divnix:main Jan 8, 2024
4 checks passed
@blaggacao
Copy link
Collaborator

blaggacao commented Jan 8, 2024

Thanks a lot for your help with maintenance! I really appreciate it.

@oneingan
Copy link
Contributor

They revert this change: numtide/devshell#293

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants