MacOS implementation of domain specific use of vpn dns #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Another related issue is #41, which discusses implementing split DNS on Windows. |
gmacon
reviewed
Jan 6, 2021
rename DomainDNSProvider to SplitDNSProvider use context manager to open file use write instead of append use if not python style
gmacon
approved these changes
Jan 6, 2021
|
Thanks @gmacon |
|
@gmacon do I need to do anything else to get this merged? would love to start using it from the release :) |
|
It would help if I remember to push "Merge Pull Request"... Sorry about that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Currently if you're using vpn-slice you can't easily give a list of domains to use the vpn dns to resolve internally. This update allows the options of
--domains-vpn-dns=domain1.com,domain2.comso that those domains will resolve using the vpn dns.macOS specifics
Notes
Related Issues
#37 #15 possibly #31 and could be updated to include #68 automatically in the future