-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DMN 1.5 - 1155-list-replace-function #657
base: master
Are you sure you want to change the base?
Conversation
@dmn-tck/contributors please review this. |
Regarding test 019: My interpretation is that this test case should return [2,4], certainly not null. Regarding test 011: |
Thanks @SimonRinguette . Good comments. Re Regarding the rounding. To my mind the spec is pretty clear - it 'must' be an integer. No provision for automatic rounding is given. When the spec says something is a must, to my mind, it is a must. Also happy to discuss.
|
On test 019: list replace ( [2, 4], function(item, newItem) item, 5) I agree with @StrayAlien . On test 011: list replace([1,2,3], 2.5, 4) I agree with @SimonRinguette. This issue was recently discussed in the RTF meeting, the final decision was to add a truncation from 2.5 to 2 to be more user-friendly and in synch with other programming languages. This approach was added in DMN 1.6 - DMN16-84. We also have similar tests see 1103-feel-substring-function |
Agreed about the case when the function doesn't return a boolean value - we agreed that it should be an error state and behave as @StrayAlien defined. |
From TCK meeting. Note to @StrayAlien, Chang test to truncate to whole number. |
Suite of pretty standard tests for the new "list replace" function. Exercises good/bad positional and named params. Also negative positioning.