Skip to content
This repository has been archived by the owner on Jun 9, 2023. It is now read-only.

Relocatable, directory organization, cwltool sync #2

Merged
merged 1 commit into from
Oct 7, 2017
Merged

Relocatable, directory organization, cwltool sync #2

merged 1 commit into from
Oct 7, 2017

Conversation

chapmanb
Copy link
Contributor

@chapmanb chapmanb commented Oct 5, 2017

Small improvements from testing with a non-Docker install:

  • Makes the script relocatable and still find necessary resource files
    so we can build a conda package.
  • Writes the created apps and workflows into a single
    directory (dx-cwl-prep) both locally and on the platform to improve cleanup
    and organization.
  • Avoid use of sudo for cleaning up directories
  • Handle previously prepared paths, either full locations on DNAnexus
    or lookups for file-* references.
  • Updates cwl-runner to match arguments in
    Support for user space docker common-workflow-language/cwltool#542

Small improvements from testing with a non-Docker install:

- Makes the script relocatable and still find necessary resource files
  so we can build a conda package.
- Writes the created apps and workflows into a single
  directory (dx-cwl-prep) both locally and on the platform to improve cleanup
  and organization.
- Avoid use of sudo for cleaning up directories
- Handle previously prepared paths, either full locations on DNAnexus
  or lookups for `file-*` references.
- Updates cwl-runner to match arguments in
  common-workflow-language/cwltool#542
Copy link
Contributor

@geetduggal geetduggal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- I'll test this more in my env, but thanks so much for these changes at this early stage!

@geetduggal geetduggal merged commit eeeb908 into dnanexus-archive:master Oct 7, 2017
@geetduggal geetduggal mentioned this pull request Oct 19, 2017
@geetduggal geetduggal added this to the beta-release milestone Oct 19, 2017
geetduggal pushed a commit that referenced this pull request Jan 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants