Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to series 44 #116

Merged
merged 16 commits into from
Feb 22, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,20 +17,20 @@ env:
- TASK="kitchen" KITCHEN_REGEXP=authoritative-multi-centos-8
- TASK="kitchen" KITCHEN_REGEXP=authoritative-multi-debian-9
- TASK="kitchen" KITCHEN_REGEXP=authoritative-multi-debian-10
- TASK="kitchen" KITCHEN_REGEXP=authoritative-multi-ubuntu-1604
- TASK="kitchen" KITCHEN_REGEXP=authoritative-multi-ubuntu-1804
- TASK="kitchen" KITCHEN_REGEXP=authoritative-multi-ubuntu-2004
- TASK="kitchen" KITCHEN_REGEXP=authoritative-postgres-centos-7
- TASK="kitchen" KITCHEN_REGEXP=authoritative-postgres-centos-8
- TASK="kitchen" KITCHEN_REGEXP=authoritative-postgres-debian-9
- TASK="kitchen" KITCHEN_REGEXP=authoritative-postgres-debian-10
# - TASK="kitchen" KITCHEN_REGEXP=authoritative-postgres-ubuntu-1604 # https://askubuntu.com/questions/830346/postgresql-server-doesnt-start
- TASK="kitchen" KITCHEN_REGEXP=authoritative-postgres-ubuntu-1804
- TASK="kitchen" KITCHEN_REGEXP=authoritative-postgres-ubuntu-2004
- TASK="kitchen" KITCHEN_REGEXP=recursor-multi-centos-7
- TASK="kitchen" KITCHEN_REGEXP=recursor-multi-centos-8
- TASK="kitchen" KITCHEN_REGEXP=recursor-multi-debian-9
- TASK="kitchen" KITCHEN_REGEXP=recursor-multi-debian-10
- TASK="kitchen" KITCHEN_REGEXP=recursor-multi-ubuntu-1604
- TASK="kitchen" KITCHEN_REGEXP=recursor-multi-ubuntu-1804
- TASK="kitchen" KITCHEN_REGEXP=recursor-multi-ubuntu-2004

matrix:
fast_finish: true
Expand Down
10 changes: 5 additions & 5 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,11 @@ We're excited that you'd like to help us with our PowerDNS cookbook project!

## Submitting issues

When submitting an issue, please check the Issues section of this repository on Github to make sure it has not already been reported. If it has been reported, then please contribute to the conversation on the issue and provide any additional information you can. If it has not been reported, please be as detailed as possible.
When submitting an issue, please check the [Issues](https://github.com/dnsimple/chef-pdns/issues) section of this repository on Github to make sure it has not already been reported. If it has been reported, then please contribute to the conversation on the issue and provide any additional information you can. If it has not been reported, please be as detailed as possible.

## Contribution process

1. Fork the repository to your own account if you have not yet done do already.
1. Fork the repository into your own account if you have not done so already.
2. Commit changes to a git branch that is named after the changes you wish to contribute.
3. Create a GitHub Pull Request for your change, following the [Pull Request Requirements](#pull-request-requirements)
4. Perform a [Code Review](#code-review-process) with the cookbook maintainers on the pull request.
Expand All @@ -18,7 +18,7 @@ When submitting an issue, please check the Issues section of this repository on
In order to maintain a high standard of compatibility and consistency for the consumers of our cookbook we like to make sure all pull requests meet the following criteria:

1. **Tests:** To ensure high quality code and protect against regressions in the future we require all changes have ample test coverage. This does not mean 100% coverage or even specific types of coverage. See the TESTING.md file for details on how to run the test suite.
2. **Passing Continuous Integration (CI):** Speaking of tests, the contributed code must pass our full suite of tests on [Travis-CI][] and show a green indicator meaning the latest build passes. If for some reason the build is failing before your pull request please raise the issue in the pull request so we may address it.
2. **Passing Continuous Integration (CI):** Speaking of tests, the contributed code must pass our full suite of tests on [Travis-CI](https://travis-ci.com/github/dnsimple/chef-pdns) and show a green indicator meaning the latest build passes. If for some reason the build is failing before your pull request, please raise the issue in the pull request so we may address it.

### Code Review Process

Expand All @@ -32,8 +32,8 @@ Once you open a pull request, cookbook maintainers will review your code using t
## Contribution Guidelines

* **DO** include tests in your pull requests where applicable
* **DONT** modify or change the version number in the metadata.rb as we prefer to control the release cycle ourselves and it makes for code merging headaches that make everyone involved pretty sad
* **DONT** modify the CHANGELOG.md in your pull request as well. The maintainers will auto-generate this before a new release.
* **DONT** modify or change the version number in the `metadata.rb` as we prefer to control the release cycle ourselves and it makes for code merging headaches that make everyone involved pretty sad
* **DONT** modify the `CHANGELOG.md` in your pull request as well. The maintainers will auto-generate this before a new release.
* **DO** remember that humans are handling your contributions so please be nice and polite when discussing anything in your pull request.

[security page]: https://dnsimple.com/security
Expand Down
Loading