Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update ci deps and jobs #127

Merged
merged 6 commits into from
Jan 6, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
---
version: 2
updates:
- package-ecosystem: "github-actions"
directory: "/"
schedule:
interval: "daily"
open-pull-requests-limit: 10
labels:
- task
- dependencies
reviewers:
- "dnsimple/sip"
52 changes: 38 additions & 14 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
@@ -1,50 +1,71 @@
---
name: ci

"on":
on:
pull_request:
push:
branches:
- main
workflow_dispatch:

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

jobs:
delivery:
cookstyle:
runs-on: ubuntu-latest
steps:
- name: Checkout Code
uses: actions/checkout@v2
uses: actions/checkout@v3
- name: Install Chef Workstation
uses: actionshub/chef-install@main
- name: Run Cookstyle
run: chef exec rake cookstyle
env:
CHEF_LICENSE: accept-no-persist
- name: Run Specs
run: chef exec rake spec
env:
CHEF_LICENSE: accept-no-persist

markdownlint-cli:
runs-on: ubuntu-latest
steps:
- name: Checkout Code
uses: actions/checkout@v2
uses: actions/checkout@v3
- name: Run markdownlint-cli
uses: nosborn/github-action-markdown-cli@v2.0.0
uses: nosborn/github-action-markdown-cli@v3.2.0
with:
files: .
config_file: ".markdownlint.yaml"

rspec:
runs-on: ubuntu-latest
steps:
- name: Checkout Code
uses: actions/checkout@v3
- name: Install Chef Workstation
uses: actionshub/chef-install@main
- name: Install Spec gems
run: chef gem install deepsort
env:
CHEF_LICENSE: accept-no-persist
- name: Rspec
run: chef exec rake spec
env:
CHEF_LICENSE: accept-no-persist

yamllint:
runs-on: ubuntu-latest
steps:
- name: Checkout Code
uses: actions/checkout@v2
uses: actions/checkout@v3
- name: Run YAML Lint
uses: actionshub/yamllint@main

integration:
needs: [delivery, markdownlint-cli, yamllint]
needs:
- cookstyle
- markdownlint-cli
- rspec
- yamllint
runs-on: ubuntu-latest
strategy:
matrix:
Expand All @@ -63,9 +84,13 @@ jobs:
continue-on-error: ${{ matrix.os == 'centos-8' }}
steps:
- name: Checkout Code
uses: actions/checkout@v2
uses: actions/checkout@v3
- name: Install Chef Workstation
uses: actionshub/chef-install@main
- name: Install Spec gems
run: chef gem install deepsort
env:
CHEF_LICENSE: accept-no-persist
- name: Run Test Kitchen
uses: actionshub/test-kitchen@main
env:
Expand All @@ -79,5 +104,4 @@ jobs:
run: |
set -x
sudo journalctl -l --since today
KITCHEN_LOCAL_YAML=kitchen.yml /usr/bin/kitchen exec \
${{ matrix.suite }}-${{ matrix.os }} -c "journalctl -l"
KITCHEN_LOCAL_YAML=kitchen.yml /usr/bin/kitchen exec ${{ matrix.suite }}-${{ matrix.os }} -c "journalctl -l"
3 changes: 3 additions & 0 deletions .yamllint
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,6 @@ rules:
line-length:
max: 256
level: warning
truthy:
ignore: |
/.github/workflows/*.yml
5 changes: 2 additions & 3 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ When submitting an issue, please check the [Issues](https://github.com/dnsimple/
In order to maintain a high standard of compatibility and consistency for the consumers of our cookbook we like to make sure all pull requests meet the following criteria:

1. **Tests:** To ensure high quality code and protect against regressions in the future we require all changes have ample test coverage. This does not mean 100% coverage or even specific types of coverage. See the TESTING.md file for details on how to run the test suite.
2. **Passing Continuous Integration (CI):** Speaking of tests, the contributed code must pass our full suite of tests on [Travis-CI](https://travis-ci.com/github/dnsimple/chef-pdns) and show a green indicator meaning the latest build passes. If for some reason the build is failing before your pull request, please raise the issue in the pull request so we may address it.
2. **Passing Continuous Integration (CI):** Speaking of tests, the contributed code must pass our full suite of tests on [GitHub](https://github.com/dnsimple/chef-pdns/actions) and show a green indicator meaning the latest build passes. If for some reason the build is failing before your pull request, please raise the issue in the pull request so we may address it.

### Code Review Process

Expand All @@ -36,5 +36,4 @@ Once you open a pull request, cookbook maintainers will review your code using t
* **DONT** modify the `CHANGELOG.md` in your pull request as well. The maintainers will auto-generate this before a new release.
* **DO** remember that humans are handling your contributions so please be nice and polite when discussing anything in your pull request.

[security page]: https://dnsimple.com/security
[Travis-CI]: https://travis-ci.com
[DNSimple Security Page](https://dnsimple.com/security)