-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding missing dependency libssl dev on source install #45
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think one file might have been added by mistake
Vagrantfile.erb
Outdated
@@ -0,0 +1,133 @@ | |||
<% config[:vagrantfiles].each do |vagrantfile| %> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need this vagrant template?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's explained on the PR @martinisoft:
test kitchen complained that it was missing.
I was unable to run integration tests without adding a vagrantfile, but I could not also find any reference to it. I have uninstalled any vagrant plugins in case it was that, but still had the problem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@therobot You might have a global kitchen file in your ~/.kitchen/config.yml
that might be referencing it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed that case too, but it was not there, I just found it here: .kitchen.local.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@therobot That isn't tracked in git (it's ignored local kitchen configs) so I'd just add Vagrantfile.erb to the gitignore in this commit to resolve that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I deleted both Vagrantfile.erb and .kitchen.local.yml I don't think I need it @martinisoft
This PR addreses #44 and it installs the missing library.
It additionally adds Vagrantfile.erb since test kitchen complained that it was missing.