Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding missing dependency libssl dev on source install #45

Merged
merged 3 commits into from
Feb 8, 2017

Conversation

therobot
Copy link
Contributor

@therobot therobot commented Feb 8, 2017

This PR addreses #44 and it installs the missing library.

It additionally adds Vagrantfile.erb since test kitchen complained that it was missing.

Copy link
Contributor

@martinisoft martinisoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think one file might have been added by mistake

Vagrantfile.erb Outdated
@@ -0,0 +1,133 @@
<% config[:vagrantfiles].each do |vagrantfile| %>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this vagrant template?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's explained on the PR @martinisoft:

test kitchen complained that it was missing.

I was unable to run integration tests without adding a vagrantfile, but I could not also find any reference to it. I have uninstalled any vagrant plugins in case it was that, but still had the problem.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@therobot You might have a global kitchen file in your ~/.kitchen/config.yml that might be referencing it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed that case too, but it was not there, I just found it here: .kitchen.local.yml

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@therobot That isn't tracked in git (it's ignored local kitchen configs) so I'd just add Vagrantfile.erb to the gitignore in this commit to resolve that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I deleted both Vagrantfile.erb and .kitchen.local.yml I don't think I need it @martinisoft

@therobot therobot merged commit e19022a into master Feb 8, 2017
@therobot therobot deleted the bugfix/missing-dependency-libssl-dev branch February 8, 2017 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants