Stopping default recursor on debian based distros for sysvinit

[therobot]

This PR fixes #77 by solution proposed in the latest comment, (see issue for complete discussion of the bug).

The solution is stopping the default recursor instance only on debian based distros for sysvinit provider.

This has been proved to pass tests in both Vagrant and Docker.

[onlyhavecans]

Duplicating the resource below is a chef 13 violation and will not work as desired in all cases. You will probably want to make an pdns_default_actions var and then set it based on the requirements and pass it to action on a single service.

[therobot]

Noted, thanks.

[martinisoft]

Cosigned about that. Resource cloning has been deprecated for some time in Chef, technically since just before Chef 11. While it is technically still supported via Chef 13, the side-affect is that you'll have the same resource being called multiple times in different ways which can make it unpredictable. See https://docs.chef.io/deprecations_resource_cloning.html about this behavior.

[martinisoft]

A way around this would be something like:

pdns_recursor_actions = [:disable]
pdns_recursor_actions = pdns_recursor_actions.unshift(:stop) if node['platform_family'] == 'debian'

service 'pdns-recursor' do
    supports restart: true, status: true
    action pdns_recursor_actions
end

[onlyhavecans]

you can also use

pdns_recursor_actions += [:stop] if node['platform_family'] == 'debian'

which is less rubyesque but I think looks cleaner

[martinisoft]

Since order of array is a thing in chef then that snippet may be an issue since the += appends. Hence my use of unshift to put stop first, not last.

[martinisoft]

You could simplify it by doing:

pdns_recursor_actions = [:disable] if node['platform_family'] == 'debian'
(pdns_recursor_actions ||= []).push(:stop)

But that might be a little too obscure?

[martinisoft]

Need to resolve the cloning issue.