Fix config permissions

[onlyhavecans]

The default permissions were too strict. We didn't want the config files writeable by PowerDNS because it's not necessary for operation, but they need to be readable x.x

This PR splits the difference by not making the files world readable but making them the group set by the resource.

This might be a touch too far, and we may want to 644 and make the user and group that set the resource.

Feedback welcome.

Fixes: #89

[martinisoft]

Is there a specific error message happening to tell you this? We may want to cover this via testing if possible.

[martinisoft]

This seems like a reasonable change. I'd prefer to have a little test coverage to ensure the permissions are set correctly to avoid this regression in the future.

[mengesb]

So reloading configuration via rec_control produces an error message when it cannot read configuration files - the error is rather non-descript, however it is an error.

#89 outlines the error experienced

[onlyhavecans]

This is awaiting #92

[onlyhavecans]

@mengesb What command exactly were you running? reload-zones I assume from your error message? I would like to write some regression tests

[mengesb]

Yeah my first command was reload-zones for the recursor, there are more that should be tested! do note that you have to pass the config name and socket dir for named instances!

[mengesb]

testing rec_control --socket-dir=/var/run/__name__ --config-name=__name__ help should show the help information. If you get the help info then all other commands should be successful

If you want to test your handling of variables in the config resources; then use get-parameter [key] to validate settings

[mengesb]

for server; it's pdnsutil

[mengesb]

Failure:

$ rec_control --socket-dir=/var/run/__instance__ --config=__instance__ reload-zones
reloading failed, see log

Success:

$ rec_control --socket-dir=/var/run/__instance__ --config=__instance__ reload-zones
ok

output it to STDOUT in all cases; exit's 0 all the time

I'll have to get you pdnsutil output later

[mengesb]

w00t!

…

On Mar 8, 2018 14:22, "David Aronsohn" ***@***.***> wrote: Merged #90 <#90>. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#90 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABUHF5YBX1LewiN-fvdACisi71Gq6MF3ks5tca8TgaJpZM4SZFXd> .