Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoids setting UserAgent on ChangeBaseUrlTo #22

Merged
merged 2 commits into from
Sep 16, 2020

Conversation

san983
Copy link
Member

@san983 san983 commented Sep 3, 2020

Fixes #21

Avoids setting UserAgent on ChangeBaseUrlTo if Client is provided with a RestClientWrapper

We should release this as a patch once merged.

If Client is setup with a RestClientWrapper, avoid overriding UserAgent in ChangeBaseUrlTo method
@san983 san983 added bug ready-for-review Pull requests that are ready to be reviewed by other team members. labels Sep 3, 2020
@san983 san983 self-assigned this Sep 3, 2020
Copy link
Contributor

@ggalmazor ggalmazor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@duduribeiro duduribeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome 💯

@san983 san983 merged commit fa9cb08 into master Sep 16, 2020
@san983 san983 deleted the 21-fixes-SetUserAgent-setting branch September 16, 2020 14:39
@san983 san983 changed the title Avoids setting UserAgent on ChangeBaseUrlTo when using Avoids setting UserAgent on ChangeBaseUrlTo Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ready-for-review Pull requests that are ready to be reviewed by other team members.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ChangeBaseUrlTo does not respect SetUserAgent
3 participants