Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moves / Migrates project to .NET standard #23

Merged
merged 10 commits into from
Oct 1, 2020
Merged

Conversation

san983
Copy link
Member

@san983 san983 commented Sep 4, 2020

Taking the path stated in #10 by @adamfisher (🙇). Note:I was not able to follow up in the original PR since it looks the branch/fork has been deleted by the author.

This PR migrates the client to .NET standard in order to make it broadly supported for the whole .NET ecosystem.

@san983 san983 added enhancement ready-for-review Pull requests that are ready to be reviewed by other team members. labels Sep 4, 2020
@san983 san983 self-assigned this Sep 4, 2020
@san983 san983 removed the ready-for-review Pull requests that are ready to be reviewed by other team members. label Sep 4, 2020
@san983 san983 added the ready-for-review Pull requests that are ready to be reviewed by other team members. label Sep 5, 2020
@san983 san983 marked this pull request as ready for review September 5, 2020 15:11
@ggalmazor
Copy link
Contributor

Do we need to update the README or CONTRIBUTING docs, @san983?

@san983 san983 removed the ready-for-review Pull requests that are ready to be reviewed by other team members. label Sep 7, 2020
@san983 san983 added the ready-for-review Pull requests that are ready to be reviewed by other team members. label Sep 8, 2020
@san983
Copy link
Member Author

san983 commented Sep 8, 2020

Do we need to update the README or CONTRIBUTING docs, @san983?

As far as I see, there is no need. But I'm open to suggestions :)

@ggalmazor
Copy link
Contributor

I think I need a bit of help. I'm getting the following error when running ./build.sh:

MacBook-Pro~/src/dnsimple/dnsimple-csharp(move-to-net-standard|✔) % ./build.sh
Feeds used:
  /Users/guillermo/.nuget/packages/
  https://api.nuget.org/v3/index.json

All packages listed in /Users/guillermo/src/dnsimple/dnsimple-csharp/tools/packages.config are already installed.

========================================
Clean
========================================

========================================
Restore-NuGet-Packages
========================================
MSBuild auto-detection: using msbuild version '15.0' from '/usr/local/Cellar/mono/6.8.0.123/lib/mono/msbuild/15.0/bin'.
/usr/local/Cellar/mono/6.8.0.123/lib/mono/msbuild/Current/bin/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.TargetFrameworkInference.targets(137,5): error NETSDK1045: The current .NET SDK does not support targeting .NET Core 3.1.  Either target .NET Core 2.1 or lower, or use a version of the .NET SDK that supports .NET Core 3.1. [/Users/guillermo/src/dnsimple/dnsimple-csharp/src/dnsimple-test/dnsimple-test.csproj]

An error occurred when executing task 'Restore-NuGet-Packages'.
Error: One or more errors occurred. (NuGet: Process returned an error (exit code 1).)
	NuGet: Process returned an error (exit code 1).

My mono version is:

MacBook-Pro~/src/dnsimple/dnsimple-csharp(move-to-net-standard|✔) % mono --version
Mono JIT compiler version 6.8.0.123 (tarball Fri May 15 17:28:53 BST 2020)
Copyright (C) 2002-2014 Novell, Inc, Xamarin Inc and Contributors. www.mono-project.com
	TLS:
	SIGSEGV:       altstack
	Notification:  kqueue
	Architecture:  amd64
	Disabled:      none
	Misc:          softdebug
	Interpreter:   yes
	LLVM:          supported, not enabled.
	Suspend:       hybrid
	GC:            sgen (concurrent by default)

Copy link
Contributor

@ggalmazor ggalmazor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I was able to build the project once I installed Visual Studio for mac. FWIW, mono installed with Homebrew didn't work for me.

Copy link
Contributor

@duduribeiro duduribeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Looks good to me @san983

@san983 san983 merged commit 946e91c into master Oct 1, 2020
@san983 san983 deleted the move-to-net-standard branch October 1, 2020 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ready-for-review Pull requests that are ready to be reviewed by other team members.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants