-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moves / Migrates project to .NET standard #23
Conversation
Do we need to update the |
As far as I see, there is no need. But I'm open to suggestions :) |
I think I need a bit of help. I'm getting the following error when running
My mono version is:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I was able to build the project once I installed Visual Studio for mac. FWIW, mono installed with Homebrew didn't work for me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
Looks good to me @san983
Taking the path stated in #10 by @adamfisher (🙇). Note:I was not able to follow up in the original PR since it looks the branch/fork has been deleted by the author.
This PR migrates the client to .NET standard in order to make it broadly supported for the whole .NET ecosystem.