-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate Domain expires_on
in favor of expires_at
#135
Conversation
We deprecated expires_on attribute in our documentation and api in favor of expires_at. This commit introcuces the new field and removes the old one. It also updates to use the new fixtures.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would result in a breaking change and thus a new major release correct? Just want us to take that decision deliberately.
@duduribeiro the only thing to keep in mind before releasing this is that clients should remain as much in sync as possible. So, if we end up not removing |
@duduribeiro the behavior in all the clients must be consistent. So this PR (and all the other clients) needs to be updated to behave as dnsimple/dnsimple-ruby#186 |
@weppos @jacegu @OleMchls |
We deprecated expires_on attribute in our documentation and api in
favor of expires_at. This commit introduces the new field and removes
the old one. It also updates to use the new fixtures.
We should do a major bump, since we are removing an attribute.
Also synced these new fixtures with the docs one