Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for key-data interface creating delegation signer records #171

Merged
merged 4 commits into from
Oct 6, 2021
Merged

Add support for key-data interface creating delegation signer records #171

merged 4 commits into from
Oct 6, 2021

Conversation

OleMchls
Copy link
Contributor

This PR:

  • Updates the fixtures from dnsimple-developer repo to reflect the latest changes to our DNSSEC-related APIs.
  • Adds new fields to affected structs.

@OleMchls OleMchls self-assigned this Sep 29, 2021
@OleMchls OleMchls requested a review from a team September 29, 2021 15:44
@jacegu
Copy link
Contributor

jacegu commented Sep 30, 2021

Not sure if you want to update the examples in the exdocs to reflect the addition of public_key and dnssec_interface_type (an example: https://github.com/dnsimple/dnsimple-elixir/blob/main/lib/dnsimple/domains.ex#L226-L232)

san983
san983 approved these changes Sep 30, 2021
View reviewed changes
Copy link
Member

@san983 san983 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Agree with @jacegu on adding the new field in the example

@OleMchls OleMchls merged commit a11a58b into main Oct 6, 2021
@weppos weppos deleted the dnssec-keydata-support branch June 15, 2022 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacegu jacegu jacegu approved these changes

@san983 san983 san983 approved these changes

Assignees

@OleMchls OleMchls

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OleMchls @jacegu @san983