Expose all information available in error responses #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As we are going to introduce more specs in this context, that won't rely on the same fixture.
With JSON responses. We are setting the ground to add the specific specs about the errors payload in the response.
This was actually a bug in the client, where we were assuming all error responses would have a JSON payload. I am replicating the behavior we currently have in the Ruby client.
We are also considering the cases in which the payload doesn't include this element and non-json-encoded 5xx responses.
jacegu
requested review from
a team and
OleMchls
and removed request for
a team
To RequestError#attribute_errors
DXTimer
approved these changes
Sep 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our error responses sometimes include an errors entry with details about errors on the attributes of the specific resource. We handle those errors via
RequestError, but we are only considering the message.This PR:
errorsattribute toDnsimple.ResponseErrorexception.errors.