Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mention how to change internal service port #2078

Closed
wants to merge 2 commits into from

Conversation

gcbw
Copy link

@gcbw gcbw commented Nov 12, 2021

This is very useful when running in host mode network.

Is often requested and this is the "official documentation" so far MariaDB/mariadb-docker#334

This is very useful when running in host mode network.

Is often requested and this is the "official documentation" so far MariaDB/mariadb-docker#334
@tianon
Copy link
Member

tianon commented Nov 13, 2021

As the CI's eventually going to point out, this change will need to move from README.md into content.md.

I'm also going to CC @grooverdan and @dbart (the MariaDB image maintainers).

@grooverdan
Copy link
Contributor

While this env obviously does work, it does look a bit out of place compared to other env variables. It also doesn't really have a 3306 default

Any reason we just couldn't recommend --port 3909 or similar in the Connect to MariaDB section which is far too docker generic at the moment? It would prevent reintroducing a MYSQL only naming and hint towards other MariaDB system server command line options that could be used by in the same way.

@gcbw
Copy link
Author

gcbw commented Nov 15, 2021

This was not intended as an improvement (which i agree with @grooverdan would be to add the explicit default and use --port receiving a proper docker composer variable). This was instead intended as simply documenting the currently accepted work around when using host-only network driver.

@yosifkit
Copy link
Member

Yeah, it might make sense to expand the "configuration without a cnf file section" to mention --port in the same way you can customize all the other MariaDB variables, via flags to mariadbd (https://github.com/docker-library/docs/tree/ee77758ebb4ab10e7165c533d887649b55510eb8/mariadb#configuration-without-a-cnf-file).

And the yaml equivalent is command:

version: '3.1'

services:

  db:
    image: mariadb
    environment:
      MYSQL_ROOT_PASSWORD: example
    command: --port 3309

grooverdan added a commit to grooverdan/docs that referenced this pull request Nov 16, 2021
As mentioned in #2708 docs documenting how to change the port,
particular for host networking was requested.

The example in "configuration without a cnf file section" was
already the default anyway (utf8), so this was just replaced.

Using MARIADB_ROOT_PASSWORD in the example to move away from
MySQL naming (still supported however).

Closes: docker-library#2078
grooverdan added a commit to grooverdan/docs that referenced this pull request Nov 16, 2021
As mentioned in #2708 docs documenting how to change the port,
particular for host networking was requested.

The example in "configuration without a cnf file section" was
already the default anyway (utf8), so this was just replaced.

Using MARIADB_ROOT_PASSWORD in the example to move away from
MySQL naming (still supported however).

Closes: docker-library#2078
grooverdan added a commit to grooverdan/docs that referenced this pull request Nov 19, 2021
As mentioned in #2708 docs documenting how to change the port,
particular for host networking was requested.

The example in "configuration without a cnf file section" was
already the default anyway (utf8), so this was just replaced.

Using MARIADB_ROOT_PASSWORD in the example to move away from
MySQL naming (still supported however).

Closes: docker-library#2078
@tianon tianon closed this in 37666d4 Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants