Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update versions.sh to filter targets correctly for pre-releases #705

Merged
merged 1 commit into from
Aug 1, 2024

Commits on Aug 1, 2024

  1. Update versions.sh to filter targets correctly for pre-releases

    This is relevant right now because 8.0.0-rc15 adds support for ubuntu 24.04 (noble), but 7.0 doesn't support it yet, so it's impossible to install the `noble` pre-release builds.
    
    This fixes the calculation of which base image to use by cross-referencing this case.  While doing so, I centralized more of the logic for when/where we need that backwards version so we don't have to do the same weird calculations in multiple places / languages (with a new `dockerNeedsVersion` field in `versions.json`).
    
    With this change, I was able to run `./versions.sh` and successfully build 8.0.0-rc15.
    tianon committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    bcb585e View commit details
    Browse the repository at this point in the history