Reduce the size of the image #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| && rm -rf /usr/local/mysql/mysql-test \ | ||
| && rm -rf /usr/local/mysql/sql-bench \ | ||
| && find /usr/local/mysql -type f -name "*.a" -delete \ | ||
| && ((find /usr/local/mysql -type f -print | xargs strip --strip-all) || true) |
There was a problem hiding this comment.
Can we swap this to use curly braces instead of parenthesis to prevent the creation of a subshell environment? See command grouping for more information. Also, can we change those double quotes around *.a to single quotes?
Could we swap the -print piping to xargs to just use -exec directly?
Combining the two we would get: && { find /usr/local/mysql -type f -executable -exec strip --strip-all '{}' + || true; }.
|
Just to note, @yosifkit made the changes we requested. Thanks for the contribution! :) |
ltangvald
added a commit
to ltangvald/mysql-1
that referenced
this pull request
Aug 20, 2018
…acle fix issue with fabric: http://bugs.mysql.com/bug.php?id=72281
ltangvald
added a commit
to ltangvald/mysql-1
that referenced
this pull request
Aug 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By combining all of the steps to download the source, build it, and clean up afterward into a single RUN command, and by adding a few extra cleanup steps and CMake options, I reduced the size of this image from about 3 GB to about 500 MB, with no loss of functionality.