Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed KeyTable refile in opendkim.conf https://serverfault.com/a/8617… #2249

Merged
merged 2 commits into from
Oct 16, 2021

Conversation

frugan-dev
Copy link
Contributor

Description

opendkim-testkey -vv returns error invalid data set type.
By removing refile: from /etc/opendkim.conf the problem seems to be solved, as explained here https://serverfault.com/a/861701/377751.

Before:

$ opendkim-testkey -vv
opendkim-testkey: using default configfile /etc/opendkim.conf
opendkim-testkey: invalid data set type

After:

$ opendkim-testkey -vv
opendkim-testkey: using default configfile /etc/opendkim.conf
opendkim-testkey: record 0 for 'mail._domainkey.domain.tld' retrieved
opendkim-testkey: checking key 'mail._domainkey.domain.tld'
opendkim-testkey: key mail._domainkey.domain.tld not secure
opendkim-testkey: 1 keys checked; 1 pass, 0 fail

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link
Member

@polarathene polarathene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine, thanks for the contribution! :)

refile: was added in the original PR introducing DKIM support which was for resolving a feature request by that same PR author, where they reference a install guide that uses refile: and I assume is the source of that choice.

I'm not aware of any valid reason we'd want regex support for KeyTable file after looking into it briefly and reviewing our usage/support.


Our opendkim tests look a tad concerning though 😅 , I'll probably address that once I start refactoring the test suite.

More info on opendkim tests needing refactor, seems when I've refactored the test suite this should be easier to support as I intend to have a proper DNS (with actual records) setup for more real-world test environment.

@casperklein casperklein added this to the v10.3.0 milestone Oct 16, 2021
@casperklein casperklein added the kind/improvement Improve an existing feature, configuration file or the documentation label Oct 16, 2021
@georglauterbach georglauterbach merged commit 0cebfde into docker-mailserver:master Oct 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/improvement Improve an existing feature, configuration file or the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants