Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] faq.md: update naked/bare domain section #2446

Merged
merged 2 commits into from
Mar 3, 2022
Merged

[docs] faq.md: update naked/bare domain section #2446

merged 2 commits into from
Mar 3, 2022

Conversation

sportshead
Copy link
Contributor

Description

Added a note to remove OVERRIDE_HOSTNAME in the env file if adding mydestination doesn't work. See #1731

Fixes #1731

Type of change

  • Improvement (non-breaking change that does improve existing functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • If necessary I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@georglauterbach georglauterbach added area/documentation kind/improvement Improve an existing feature, configuration file or the documentation labels Mar 1, 2022
@georglauterbach
Copy link
Member

georglauterbach commented Mar 1, 2022

Thank you for your first contribution.

--

@polarathene I remember there were some discussions about this variable. I'm currently using it so set my hostnamen In Kubernetes. But the variable may not be perfect - is there a replacement planned or do we want to adjust the working, or domething completely different?

polarathene
polarathene previously approved these changes Mar 1, 2022
@polarathene
Copy link
Member

But the variable may not be perfect - is there a replacement planned or do we want to adjust the working, or domething completely different?

I'm unable to contribute until I restore my main PC into a working/bootable state. My replacement monitor arrived yesterday, waiting on a few more components that should arrive this week, then I should be able to attempt a restore/backup + fresh OS install. All my DMS related work is on that systems disks 😅

IIRC, I had notes on how to approach that and being able to run our entire test suite easily with several different configurations would help establish confidence in dropping/replacing the ENV. Without access to my notes, I can't really comment more about it :(

I only recall the use-cases for it with k8s and also host network. I will likely be prioritizing other tasks for DMS when I can contribute again, but if someone wants to look further into this topic that is welcomed 👍

georglauterbach
georglauterbach previously approved these changes Mar 1, 2022
docs/content/faq.md Outdated Show resolved Hide resolved
@sportshead sportshead changed the title [docs] faq.md: update naked/bare domain section [DRAFT] [docs] faq.md: update naked/bare domain section Mar 2, 2022
@sportshead
Copy link
Contributor Author

Will force push to fix the commits

casperklein
casperklein previously approved these changes Mar 2, 2022
Added a note to remove `OVERRIDE_HOSTNAME` in the env file if adding `mydestination` doesn't work. See #1731

Co-authored-by: Casper <casperklein@users.noreply.github.com>
@sportshead sportshead changed the title [DRAFT] [docs] faq.md: update naked/bare domain section [docs] faq.md: update naked/bare domain section Mar 2, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Mar 3, 2022

Documentation preview for this PR is ready! 🎉

Built with commit: 7165ec4

@georglauterbach georglauterbach merged commit fd4beba into docker-mailserver:master Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation kind/improvement Improve an existing feature, configuration file or the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[POSTFIX] do not list domain mydomain.tld in BOTH mydestination and virtual_mailbox_domains
4 participants