Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove legacy ENV SASL_PASSWD #2946

Merged

Conversation

polarathene
Copy link
Member

Description

As per deprecation notice from v11.3 release notes, and a related prior PR; this ENV is to be removed.

It's no longer considered useful, and none of the tests that configured it were actually using it for relaying anything.

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)
  • New and existing unit tests pass locally with my changes

@polarathene polarathene added service/postfix area/scripts kind/improvement Improve an existing feature, configuration file or the documentation area/configuration (file) labels Dec 22, 2022
@polarathene polarathene added this to the v12.0.0 milestone Dec 22, 2022
@polarathene polarathene self-assigned this Dec 22, 2022
Copy link
Member

@georglauterbach georglauterbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good, just this one change which would be inconsistent with our style guide. Otherwise, LGTM 👍🏼

target/scripts/helpers/relay.sh Outdated Show resolved Hide resolved
polarathene and others added 3 commits December 23, 2022 14:57
Co-authored-by: Georg Lauterbach <44545919+georglauterbach@users.noreply.github.com>
@github-actions
Copy link
Contributor

Documentation preview for this PR is ready! 🎉

Built with commit: 84af6c5

@polarathene polarathene merged commit fe21fe7 into docker-mailserver:master Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/configuration (file) area/scripts kind/improvement Improve an existing feature, configuration file or the documentation service/postfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants