Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Example - Integrating Crowdsec #3651

Merged
merged 2 commits into from
Nov 25, 2023

Conversation

mivek
Copy link
Contributor

@mivek mivek commented Nov 22, 2023

Description

I added a page explaining how to use crowdsec with docker-mailserver.
The page is not a complete tutorial on how to install and configure crowdsec but covers the docker-mailserver logs parsing by crowdsec.

I added the page under examples/tutorials

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation (README.md or the documentation under docs/)

Copy link
Member

@polarathene polarathene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

I also really like how you've leveraged the admonition types and respected out link conventions ❤️

Some typos to address and minor revisions, but otherwise great work! 😎


We are looking at bringing Vector into DMS at some point to improve our logging support. You may want to subscribe to that issue in the event your guide here needs to be adjusted.

docs/content/examples/tutorials/crowdsec.md Outdated Show resolved Hide resolved
docs/content/examples/tutorials/crowdsec.md Outdated Show resolved Hide resolved
docs/content/examples/tutorials/crowdsec.md Outdated Show resolved Hide resolved
docs/content/examples/tutorials/crowdsec.md Outdated Show resolved Hide resolved
docs/content/examples/tutorials/crowdsec.md Outdated Show resolved Hide resolved
docs/mkdocs.yml Outdated Show resolved Hide resolved
@mivek
Copy link
Contributor Author

mivek commented Nov 23, 2023

Thank you @polarathene for you feedback, I applied the suggested changes.

I will squash the commits when the PR is approved.

Copy link
Member

@polarathene polarathene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@georglauterbach do you want to squeeze this into the v13 release or defer to v13.1?

@polarathene polarathene changed the title Docs: Crowdsec integration docs: Example - Integrating Crowdsec Nov 23, 2023
@polarathene polarathene mentioned this pull request Nov 25, 2023
4 tasks
@georglauterbach georglauterbach modified the milestones: v13.1.0, v13.0.0 Nov 25, 2023
Copy link
Contributor

Documentation preview for this PR is ready! 🎉

Built with commit: 999bf37

@georglauterbach
Copy link
Member

Squashing this and #3654 into v13.0.0 no problem 🚀

@georglauterbach georglauterbach merged commit cedd360 into docker-mailserver:master Nov 25, 2023
3 checks passed
@mivek mivek deleted the docs-crowdsec branch November 25, 2023 14:04
@williamdes
Copy link
Contributor

williamdes commented Dec 8, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants