Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add "rootless mode" to exceptions of "Privileged user requirement" #5359

Closed
wants to merge 2 commits into from

Conversation

Javiery3889
Copy link

@Javiery3889 Javiery3889 commented Aug 19, 2024

Modify source files for docs instead as mentioned in docker/docs#20637.

@Javiery3889 Javiery3889 requested review from thaJeztah and a team as code owners August 19, 2024 15:40
@Javiery3889 Javiery3889 changed the title Add "rootless mode" to exceptions of "Privileged user requirement" docs: add "rootless mode" to exceptions of "Privileged user requirement" Aug 19, 2024
@dvdksn
Copy link
Contributor

dvdksn commented Aug 19, 2024

Thank you for contributing! It appears your commit message is missing a DCO sign-off,
causing the DCO check to fail.

We require all commit messages to have a Signed-off-by line with your name
and e-mail (see "Sign your work"
in the CONTRIBUTING.md in this repository), which looks something like:

Signed-off-by: YourFirsName YourLastName <yourname@example.org>

There is no need to open a new pull request, but to fix this (and make CI pass),
you need to amend the commit(s) in this pull request, and "force push" the amended
commit.

Unfortunately, it's not possible to do so through GitHub's web UI, so this needs
to be done through the git commandline.

You can find some instructions in the output of the DCO check (which can be found
in the "checks" tab on this pull request), as well as in the Moby contributing guide.

Steps to do so "roughly" come down to:

  1. Set your name and e-mail in git's configuration:

    git config --global user.name "YourFirstName YourLastName"
    git config --global user.email "yourname@example.org"

    (Make sure to use your real name (not your GitHub username/handle) and e-mail)

  2. Clone your fork locally

  3. Check out the branch associated with this pull request

  4. Sign-off and amend the existing commit(s)

    git commit --amend --no-edit --signoff

    If your pull request contains multiple commits, either squash the commits (if
    needed) or sign-off each individual commit.

  5. Force push your branch to GitHub (using the --force or --force-with-lease flags) to update the pull request.

Sorry for the hassle (I wish GitHub would make this a bit easier to do), and let me know if you need help or more detailed instructions!

@codecov-commenter
Copy link

codecov-commenter commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.78%. Comparing base (a464a63) to head (0fe3366).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5359   +/-   ##
=======================================
  Coverage   59.78%   59.78%           
=======================================
  Files         345      345           
  Lines       23394    23394           
=======================================
  Hits        13985    13985           
  Misses       8438     8438           
  Partials      971      971           

Signed-off-by: Javier Yong <javiery3889@gmail.com>
@Javiery3889
Copy link
Author

Hi @dvdksn, my sincere apologies! Thank you for the in-depth instructions, the sign-off should be reflected for the commit!

@Javiery3889
Copy link
Author

Hi @laurazard @vvoland, I notice that this PR has a merge conflict. Would you prefer if I resolve the conflict and request for approval again?

@laurazard
Copy link
Member

Hi @Javiery3889! Yes, we'd appreciate if you could resolve the conflict and then we can merge :)

Signed-off-by: Javier Yong <javiery3889@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants