[WIP] config: Normalize internal volumes path on Windows. #6201
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See docker/for-win#1829.
Basically, bind mounts using UNIX paths are not valid when running docker-compose on Windows when running Docker for Windows unless
COMPOSE_CONVERT_WINDOWS_PATH
is set.This PR solves the problem by forcing the denormalization of the internal paths if the running platform is Windows or if
COMPOSE_FOR_WINDOWS_HOST
is set (not just ifCOMPOSE_CONVERT_WINDOWS_PATH
is set).Given
docker-compose.yml
:Previous behavior
Path
/var/run/docker.sock
is converted to\\var\\run\\docker.sock
and Docker for Windows cannot find this path.New behavior
Path
/var/run/docker.sock
is reconverted from\\var\\run\\docker.sock
back to/var/run/docker.sock
which is intelligible for Docker for Windows.Concerns
Or:
Resolves docker/for-win#1829