Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Container creation does not support passing the platform #2822

Closed
felixfontein opened this issue Apr 17, 2021 · 3 comments · Fixed by #2927
Closed

Container creation does not support passing the platform #2822

felixfontein opened this issue Apr 17, 2021 · 3 comments · Fixed by #2927

Comments

@felixfontein
Copy link
Contributor

While this is not documented in the API docs (https://docs.docker.com/engine/api/v1.41/#operation/ContainerCreate), the Go client uses that: https://github.com/docker/cli/blob/master/vendor/github.com/docker/docker/client/container_create.go#L42

It would be great if Docker SDK for Python could support the platform parameter for container creation as well.

@felixfontein
Copy link
Contributor Author

This issue is about the low-level API, not the high-level API. The high-level API supports that parameter, but uses it differently than the docker CLI tool: the high-level API only uses it for pulling images, while the docker CLI tool passes it on for the create command to the daemon as well.

@JonZeolla
Copy link

I would also like this feature

@felixfontein
Copy link
Contributor Author

I tried to implement it in #2927.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants