Add platform parameter for create_container() #2927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixfontein
requested review from
aiordache and
ulyssessouza
as code owners
Signed-off-by: Felix Fontein <felix@fontein.de>
Signed-off-by: Felix Fontein <felix@fontein.de>
felixfontein
force-pushed
the
platform
branch
from
bb70d51
to
e7f1b4e
Compare
JonZeolla
approved these changes
Dec 22, 2021
|
This is super helpful for people on ARM & M1 mac's trying to work with non-dual architectures. Really hoping we can get unblocked starting the containers we need on our devmachines soon! Apologies for the ping but @aiordache, @ulyssessouza, would love to see this great work move forward if we can. 🚀 |
|
@milas any chance you could take a look at this PR? |
Signed-off-by: Milas Bowman <milas.bowman@docker.com>
nicksieger
approved these changes
Jul 29, 2022
|
@JonZeolla @nicksieger @milas thanks for reviewing and merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The query parameter
platformapparently was added for API version 1.41 (see https://github.com/docker/cli/blob/fe93451cf7d26fd211c4f4c2f55d32022294b628/vendor/github.com/docker/docker/client/container_create.go#L35-L42) and is used by the Docker CLI, but unfortunately is not documented in the API docs (https://docs.docker.com/engine/api/v1.41/#operation/ContainerCreate).Fixes #2822.