Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SlevomatCodingStandard.Classes.UnusedPrivateElements #237

Merged
merged 1 commit into from
Feb 21, 2021
Merged

Remove SlevomatCodingStandard.Classes.UnusedPrivateElements #237

merged 1 commit into from
Feb 21, 2021

Conversation

morozov
Copy link
Member

@morozov morozov commented Feb 21, 2021

UnusedPrivateElements won't be supported by the upstream standard starting 7.0.0 (slevomat/coding-standard@bcbf756). Because of that, it’s currently impossible to use the Doctrine standard with dev-master of Slevomat which in turn has some improvements for PHP 8 support.

@morozov morozov requested a review from a team as a code owner February 21, 2021 18:33
@greg0ire greg0ire merged commit fb2caa8 into doctrine:8.2.x Feb 21, 2021
@greg0ire
Copy link
Member

Thanks @morozov !

@morozov morozov deleted the removed-unused-private branch February 21, 2021 20:15
@greg0ire greg0ire added this to the 8.2.1 milestone Apr 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants