Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for PHP 8 #257

Merged
merged 1 commit into from
Jul 20, 2021
Merged

Add tests for PHP 8 #257

merged 1 commit into from
Jul 20, 2021

Conversation

simPod
Copy link
Contributor

@simPod simPod commented Jul 19, 2021

I tried applying patches over themselves (e.g. apply 7.4 patch and then 8.0 patch over that 7.4 patch) but maintainability of that approach sucks. It's better to have a full patch for concrete version. It's easier to apply and reverse one patch instead of multiple ones and also single patch works well with update-compatibility-patch make target.

@greg0ire greg0ire requested a review from a team July 20, 2021 10:24
@greg0ire greg0ire merged commit 88be266 into doctrine:9.0.x Jul 20, 2021
@greg0ire
Copy link
Member

Thanks @simPod !

@greg0ire greg0ire added this to the 9.0.1 milestone Jul 20, 2021
@simPod simPod deleted the php8 branch July 20, 2021 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants