Update RHF-MUI to be compatible with MUI v6 #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PR was validated by (successfully) linting and building all targets, and comparing the storybook with the published version having found no visual or behavioural differences. Since no code changes were necessary this might not even need a new major release :) There are two notable changes from the migration guide that have not been adopted yet: https://mui.com/material-ui/migration/upgrade-to-v6/ - RHF-MUI still targets ES5, but with MUI dropping support for IE 11 upping the build target to something more modern is worth considering. - MUI v6 is (forward) compatible with the upcoming React 19 release as well, however I have not tested this for RHF-MUI. When a MUI X dependency is used (i.e. @mui/x-date-pickers) then, when wanting to use it together with MUI v6, the minimum version is MUI X v7.15 as that adds the peer dependency allowance. However, since it still supports v5 as well, I did not update the minimum MUI X version in package.json. Fixes dohomi#273
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Please take a look! I think I've built and tested everything I can in the library, however a double check would definitely be appreciated. I had expected that code changes would've been necessary, but there were none. There are a number of deprecations in v6 that RHF-MUI is subject to, particularly moving to |
|
@beverloo thanks for taking your time I published 7.1.0 with the compatibility for MUI v6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR was validated by (successfully) linting and building all targets, and comparing the storybook with the published version having found no visual or behavioural differences. Since no code changes were necessary this might not even need a new major release :)
There are two notable changes from the migration guide that have not been adopted yet:
https://mui.com/material-ui/migration/upgrade-to-v6/
When a MUI X dependency is used (i.e. @mui/x-date-pickers) then, when wanting to use it together with MUI v6, the minimum version is MUI X v7.15 as that adds the peer dependency allowance. However, since it still supports v5 as well, I did not update the minimum MUI X version in package.json.
Fixes #273