Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[util] Strict float emulation for Supreme Commander #2682

Merged
merged 1 commit into from
Jun 12, 2022
Merged

[util] Strict float emulation for Supreme Commander #2682

merged 1 commit into from
Jun 12, 2022

Conversation

Blisto91
Copy link
Contributor

Fixes some missing effects for Supreme Commander and it's expansion.

Closes #2638

@misyltoad misyltoad merged commit 968f0cd into doitsujin:master Jun 12, 2022
@Flypaste
Copy link

Flypaste commented Jun 13, 2022

I don't understand what's going on very well; but there's a very large post-launch support for this game using a custom lobby, and it needs to call the game as forgedalliance.exe for legal reasons since they've done exe patches. So if the fix in proton could apply based on steamapp ID rather than executable name (9420 in this case) to ensure compatibility with this lobby, that would be very much appreciated.

@K0bin
Copy link
Collaborator

K0bin commented Jun 13, 2022

We can't base it off the Steam ID but we could add another exe name.

@Flypaste
Copy link

Alright, thanks. The name we'd need is "ForgedAlliance.exe". I have no idea if it's case sensitive lol.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing particle effects in Supreme Commander
4 participants