Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[d3d9] Reject Reset if there's any remaining DEFAULT resources #3486

Merged
merged 1 commit into from
Jun 13, 2023

Conversation

K0bin
Copy link
Collaborator

@K0bin K0bin commented Jun 9, 2023

Fixes #3472

@K0bin K0bin added the d3d9 label Jun 9, 2023
@K0bin K0bin requested a review from misyltoad June 9, 2023 23:19
@WinterSnowfall
Copy link
Contributor

... and don't forget to also include a config option for the game. Speaking of which, the existing regex should probably be expanded to include the GOG release, which uses kof13_win32_Release.exe.

@K0bin
Copy link
Collaborator Author

K0bin commented Jun 10, 2023

I'm currently considering doing this by default for every game.

@K0bin K0bin force-pushed the accurate-device-lost branch 2 times, most recently from e1d063c to 4ecaf4c Compare June 11, 2023 16:32
@K0bin
Copy link
Collaborator Author

K0bin commented Jun 11, 2023

Changed it so it's done by default. I also tested how D3D9Ex handles this. This will need some more testing though,

@K0bin K0bin force-pushed the accurate-device-lost branch 3 times, most recently from b22f4bf to 83c8e84 Compare June 12, 2023 00:21
@K0bin
Copy link
Collaborator Author

K0bin commented Jun 12, 2023

Okay, I think I got this right now but it'll take a lot of testing.

Reset is all around more accurate now based on tests.

  • State is always reset regardless of whether the Reset call fails
  • D3D9Ex doesn't care about DEFAULT resources
  • D3D9Ex does NOT reset the state except for the bound render targets.

@K0bin K0bin marked this pull request as ready for review June 12, 2023 00:24
@K0bin K0bin force-pushed the accurate-device-lost branch 2 times, most recently from ee99625 to 21345a0 Compare June 12, 2023 00:35
@pchome
Copy link
Contributor

pchome commented Jun 12, 2023

Shouldn't all those "Device reset failed" messages have WARN log level?

@K0bin
Copy link
Collaborator Author

K0bin commented Jun 12, 2023

Shouldn't all those "Device reset failed" messages have WARN log level?

I guess you could argue that. In practice it's probably gonna be something that happens in some games and is totally benign.

@WinterSnowfall
Copy link
Contributor

My 2 cents: rather than getting issue reports from people believing something abnormal is happening, I'd keep it swept under the proverbial rug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[d3d9] THE KING OF FIGHTERS XIII: STEAM EDITION: Missing Graphics
4 participants