-
Notifications
You must be signed in to change notification settings - Fork 831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[d3d9] Reject Reset if there's any remaining DEFAULT resources #3486
Conversation
8ec582d
to
1d89d99
Compare
... and don't forget to also include a config option for the game. Speaking of which, the existing regex should probably be expanded to include the GOG release, which uses |
I'm currently considering doing this by default for every game. |
e1d063c
to
4ecaf4c
Compare
Changed it so it's done by default. I also tested how D3D9Ex handles this. This will need some more testing though, |
b22f4bf
to
83c8e84
Compare
Okay, I think I got this right now but it'll take a lot of testing. Reset is all around more accurate now based on tests.
|
ee99625
to
21345a0
Compare
Shouldn't all those "Device reset failed" messages have WARN log level? |
I guess you could argue that. In practice it's probably gonna be something that happens in some games and is totally benign. |
21345a0
to
cad3210
Compare
My 2 cents: rather than getting issue reports from people believing something abnormal is happening, I'd keep it swept under the proverbial rug. |
Fixes #3472